hilojs Issue Tracker Rss Feed

Commented Unassigned: Exception is thrown when Pictures folder is empty [3]

fmartinez — Fri, 03 May 2013 17:25:33 GMT

If the __Pictures__ folder of the current user doesn't contain any images when the sample is run, the following exception is thrown:
```
Exception is about to be caught by JavaScript library code at line 38, column 13 in ms-appx://microsoft.sdksamples.hilo.js/Hilo/Picture.js

0x800a138f - JavaScript runtime error: Unable to get property 'name' of undefined or null reference

If there is a handler for this exception, the program may be safely continued.
```
This exception is being thrown inside the __PictureConstructor__ function (of the __Picture.js__ file) due to the __file__ argument being ___undefined___.

Regards,

Damian Cherubini
http://blogs.southworks.net/dcherubini

Comments: Hi, I've found that the problem was related to the __processNextFile__ function in the ___createViewModels__ function from the __imageQueryBuilder.js__, which was trying to call the __Hilo.Picture__ function on an invalid index of the array from the Pictures folder. In order to workaround this issue you can change the code from the __processNextFile__ function for the following one: ```JS function processNextFile() { if (index < 0) { complete(results); } else if (!proceed) { error("Cancel"); } else { var file = files[index]; results[index] = new Hilo.Picture(file); index--; setImmediate(processNextFile); } } ``` Regards, Federico Martinez http://blogs.southworks.net/fmartinez

Created Unassigned: Exception is thrown when Pictures folder is empty [3]

DCherubini — Thu, 25 Apr 2013 16:39:35 GMT

Commented Issue: C:\Projects\Repositories\.bin\hilojs\Hilo\Hilo.jsproj : error : Error HRESULT E_FAIL has been returned from a call to a COM component. [2]

rhp_74 — Thu, 14 Mar 2013 14:52:57 GMT

I cannot open the .sln from Visual Studio as the Hilo project fails to load with:

C:\Projects\Repositories\.bin\hilojs\Hilo\Hilo.jsproj : error : Error HRESULT E_FAIL has been returned from a call to a COM component.

Any thoughts,
-Roberto
Comments: I found out what the problem was, it seems the HgSccPackage (http://www.newsupaplex.pp.ru/hgscc_news_eng.html) doesn't like the HiLo .jsproj. I set my Visual Studio to not use any Source Control Provider, and now everything is peachy. Regards, -Roberto

Created Issue: C:\Projects\Repositories\.bin\hilojs\Hilo\Hilo.jsproj : error : Error HRESULT E_FAIL has been returned from a call to a COM component. [2]

rhp_74 — Fri, 01 Mar 2013 15:20:16 GMT

Closed Issue: Code cleanup/review pass [1]

bennage — Fri, 24 Aug 2012 23:59:25 GMT

I did a quick code review pass and found a few things to tweak.

1) Inconsistent use of `document.getElementById('foo')` vs. `document.querySelector('#foo')`.
Technically `document.getElementById('foo')` is faster, but if you're repeatedly grabbing the same element you should store it in a variable or property then the cost isn't important. See http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fdetail%2fdetail.js

2) Avoid DOM0 event handler assignment like ` document.body.onkeyup = ...` and instead use `addEventListener`
http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fPageControlNavigator.js

3) Move frequently assigned elements or DOM objects into a variable. So instead of `document.body.style.height = ...` then `document.body.style.width = ...` then `document.body.style.color = ...`, do `var bodyStyle = document.body.style;` and then the style modifications.
Comments: Updates in http://hilojs.codeplex.com/SourceControl/changeset/7b904fe39427 I only found a few instances of #3. On whole, we've tried to avoid lengthy reference chains. If you come across more instance, please raise them. Thanks!

Commented Issue: Code cleanup/review pass [1]

jdalton — Fri, 24 Aug 2012 23:15:40 GMT

I did a quick code review pass and found a few things to tweak.

1) Inconsistent use of `document.getElementById('foo')` vs. `document.querySelector('#foo')`.
Technically `document.getElementById('foo')` is faster, but if you're repeatedly grabbing the same element you should store it in a variable or property then the cost isn't important. See http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fdetail%2fdetail.js

2) Avoid DOM0 event handler assignment like ` document.body.onkeyup = ...` and instead use `addEventListener`
http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fPageControlNavigator.js

3) Move frequently assigned elements or DOM objects into a variable. So instead of `document.body.style.height = ...` then `document.body.style.width = ...` then `document.body.style.color = ...`, do `var bodyStyle = document.body.style;` and then the style modifications.
Comments: @Bennage on #3 I avoided mentioning perf because in most cases it's a micro-optimization, I prefer it for readability. http://jsperf.com/document-body-vs/2#chart=bar

Commented Issue: Code cleanup/review pass [1]

bennage — Fri, 24 Aug 2012 23:00:12 GMT

I did a quick code review pass and found a few things to tweak.

1) Inconsistent use of `document.getElementById('foo')` vs. `document.querySelector('#foo')`.
Technically `document.getElementById('foo')` is faster, but if you're repeatedly grabbing the same element you should store it in a variable or property then the cost isn't important. See http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fdetail%2fdetail.js

2) Avoid DOM0 event handler assignment like ` document.body.onkeyup = ...` and instead use `addEventListener`
http://hilojs.codeplex.com/SourceControl/changeset/view/ee9ae3abeb43#Hilo%2fHilo%2fPageControlNavigator.js

3) Move frequently assigned elements or DOM objects into a variable. So instead of `document.body.style.height = ...` then `document.body.style.width = ...` then `document.body.style.color = ...`, do `var bodyStyle = document.body.style;` and then the style modifications.
Comments: What's interesting about PageControlNavigator.js is that is out-of-the-box Visual Studio template. But yeah, I totally agree about `addEventListener`. For number 3, is your primary reason perf related? I've read that it doesn't matter as much in modern browsers. Though in general I prefer approach you recommend for readability.

Created Issue: Code cleanup/review pass [1]

jdalton — Fri, 24 Aug 2012 22:45:43 GMT